PhantomLabsAI / PhantomPulse — Proposed PR Plan (no push)

This plan is structured as small, reviewable PRs.

PR 1 — Fix Apply Now/Login routing + auth default

Branch: fix/client-auth-default-register

Commits:

1. fix(auth): default /client/auth to register and honor mode=login|register
   • In ClientAuth.tsx, replace the current isLogin initialization with explicit mode parsing.
   • Keep toggle button behavior.
2. fix(marketing): Apply Now -> register, Login -> login
   • In Navigation.tsx, set:
     • Login: /client/auth?mode=login
     • Apply Now: /client/auth?mode=register

Acceptance: Apply Now always shows registration form; direct /client/auth?mode=login shows login.

PR 2 — Make marketing section nav work off-homepage

Branch: fix/navigation-cross-page-section-links

Commits:

1. fix(nav): section buttons navigate to /#section when not on /
   • If not on /, use wouter setLocation('/#pricing') (or similar) instead of scrollIntoView.
2. feat(home): scroll to hash section on initial load
   • On Home mount, read window.location.hash and scroll.

Acceptance: Clicking Pricing/FAQ/How It Works from /products or /client/auth lands user at the right Home section.

PR 3 — Add legal/compliance pages

Branch: feat/legal-pages

Commits:

1. feat(legal): add routes and pages for /privacy /terms /risk
   • Add simple static pages in client/src/pages/.
   • Wire into client/src/App.tsx routes.
2. chore(footer): link legal pages and support contact

Acceptance: Footer links exist; pages render; routing works.

PR 4 — Remove JWT secret fallback (prod safety)

Branch: chore/security-require-session-secret

Commits:

1. chore(security): require SESSION_SECRET when NODE_ENV=production
   • Fail fast if missing; remove fallback-secret-key.
2. docs(env): document required env vars for production

Acceptance: Production boot fails without SESSION_SECRET; local dev still works with .env.

PR 5 — Dashboard loading/error standardization

Branch: ux/dashboard-loading-error-states

Commits:

1. ux(dashboard): add loading + error states to Overview
2. ux(dashboard): add shared <PageState> components (loading/error/empty)

Acceptance: No dashboard page silently renders blank/placeholder data when API fails.

PR 6 — Cleanup: remove or rehome legacy ClientDashboard

Branch: chore/remove-legacy-client-dashboard

Commits:

1. chore(client): remove unused ClientDashboard page or add route if intended

Acceptance: No dead code; maintainers know the intended dashboard entry.